Automate rest api docs generation #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicpuppa
force-pushed
the
sync-camunda-rest-api
branch
8 times, most recently
from
84f5737 to
0e0f8cc
Compare
nicpuppa
force-pushed
the
sync-camunda-rest-api
branch
12 times, most recently
from
112141c to
4a725bc
Compare
nicpuppa
force-pushed
the
sync-camunda-rest-api
branch
8 times, most recently
from
9ab8922 to
c62a0a2
Compare
nicpuppa
force-pushed
the
sync-camunda-rest-api
branch
4 times, most recently
from
3f0ff02 to
387f0b7
Compare
nicpuppa
force-pushed
the
sync-camunda-rest-api
branch
from
387f0b7 to
86d5f79
Compare
nicpuppa
requested review from
akeller,
pepopowitz,
koevskinikola and
megglos
and removed request for
koevskinikola
nicpuppa
force-pushed
the
sync-camunda-rest-api
branch
from
86d5f79 to
0d3196f
Compare
nicpuppa
commented
Aug 27, 2024
nicpuppa
commented
Aug 27, 2024
akeller
added
the
dx
pepopowitz
requested changes
Aug 27, 2024
There was a problem hiding this comment.
I love this, and we (read: me, probably) should think about extending this to other APIs when possible.
I have some blocking feedback, especially around details of the PR that gets opened. I also started some conversations in my feedback, and we should not hesitate in those conversations to qualify things as worthy of follow-up PRs instead of blocking this one.
The image used for our GH runners contains nvm, likely we are using an older version of nvm not available in the runner
|
Hey @pepopowitz @akeller I addressed all the suggestions, please have another look 😄 |
nicpuppa
force-pushed
the
sync-camunda-rest-api
branch
from
a61cbcd to
31d557c
Compare
pepopowitz
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a GH workflow to automate the creation of REST API specification in our documentation