-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update screenshots to Desktop Modeler 5.26.0 #4147
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
This does not look right as the mentioned files are replaced in the PR. |
CC @pepopowitz, not sure if I'm missing something here? FYI @barmac I'm pushing out a release now, but can ship out another once this is approved 👍 |
Yes, that's exactly what triggered this message, is that you replaced these files in |
Thanks for clarification. That wasn't intentional but just a side effect of the new images being exactly identical as the old ones. So git didn't detect any changes as there were none for these 3 files 😅. That's OK though and we can proceed with the PR.
Sure, thank you for update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The footer looks correctly updated for these screenshots, so it gets my 👍
Related to camunda/camunda-modeler#4416
Description
This PR updates the screenshots to Desktop Modeler 5.26.0
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).