Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update screenshots to Desktop Modeler 5.26.0 #4147

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Aug 13, 2024

Related to camunda/camunda-modeler#4416

Description

This PR updates the screenshots to Desktop Modeler 5.26.0

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@barmac barmac requested review from nikku, a team and jarekdanielak and removed request for a team August 13, 2024 07:29
Copy link
Contributor

github-actions bot commented Aug 13, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/deploy-icon.png
  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/start-instance-icon.png
  • versioned_docs/version-8.5/self-managed/modeler/desktop-modeler/img/deploy-icon.png

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@barmac barmac requested review from philippfromme and marstamm and removed request for jarekdanielak August 13, 2024 09:36
@barmac barmac added the 8.6.0-alpha4 August 2024 alpha release label Aug 13, 2024
@barmac
Copy link
Contributor Author

barmac commented Aug 13, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/deploy-icon.png
  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/start-instance-icon.png
  • versioned_docs/version-8.5/self-managed/modeler/desktop-modeler/img/deploy-icon.png

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

This does not look right as the mentioned files are replaced in the PR.

@christinaausley
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?
These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/deploy-icon.png
  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/start-instance-icon.png
  • versioned_docs/version-8.5/self-managed/modeler/desktop-modeler/img/deploy-icon.png

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

This does not look right as the mentioned files are replaced in the PR.

CC @pepopowitz, not sure if I'm missing something here?

FYI @barmac I'm pushing out a release now, but can ship out another once this is approved 👍

@pepopowitz
Copy link
Collaborator

👋 🤖 🤔 Hello! Did you make your changes in all the right places?
These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/deploy-icon.png
  • versioned_docs/version-8.5/components/modeler/desktop-modeler/img/start-instance-icon.png
  • versioned_docs/version-8.5/self-managed/modeler/desktop-modeler/img/deploy-icon.png

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

This does not look right as the mentioned files are replaced in the PR.

Yes, that's exactly what triggered this message, is that you replaced these files in /versioned_docs/version-8.5/, but not in /docs/. If you did that intentionally, you can ignore the message.

@barmac
Copy link
Contributor Author

barmac commented Aug 14, 2024

Thanks for clarification. That wasn't intentional but just a side effect of the new images being exactly identical as the old ones. So git didn't detect any changes as there were none for these 3 files 😅. That's OK though and we can proceed with the PR.

FYI @barmac I'm pushing out a release now, but can ship out another once this is approved 👍

Sure, thank you for update.

@akeller akeller added component:modeler Issues related with Modeler project component:desktop-modeler Issues related with Desktop Modeler labels Aug 15, 2024
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The footer looks correctly updated for these screenshots, so it gets my 👍

@nikku nikku merged commit c0882a0 into main Aug 15, 2024
16 checks passed
@nikku nikku deleted the modeler-5-26 branch August 15, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0-alpha4 August 2024 alpha release component:desktop-modeler Issues related with Desktop Modeler component:modeler Issues related with Modeler project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants