Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add disclaimer on user-task-restrictions #4127

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

nathansandi
Copy link
Contributor

Description

add a disclaimer on user task restrictions in order to clarify the change takes some time to take effect.

When should this change go live?

  • This is already available but undocumented and should be released within a week.
  • There is no urgency with this change and can be released at any time.

PR Checklist

@nathansandi nathansandi added the component:tasklist Issues related with Tasklist project label Aug 8, 2024
@nathansandi nathansandi requested a review from akeller August 8, 2024 08:33
@mesellings
Copy link
Contributor

mesellings commented Aug 8, 2024

@nathansandi I can review this for you 👍

@mesellings mesellings self-requested a review August 8, 2024 10:14
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this to read as follows (assuming that I have understood correctly, and that the note means that any enable/disable change requires a Tasklist restart):

Changes to this setting can take a few minutes to be applied, as it requires a Tasklist restart.

Additionally, though this is not the PR scope, I would change the previous sentence as follows:

User task access restrictions are enabled by default. To disable them, navigate to Console settings and turn off the Enforce user task restrictions toggle.

@mesellings
Copy link
Contributor

@nathansandi I have added some review comments, but as you specifically requested @akeller for the review I have left the approval.

@akeller
Copy link
Member

akeller commented Aug 8, 2024

I would change this to read as follows (assuming that I have understood correctly, and that the note means that any enable/disable change requires a Tasklist restart):

Changes to this setting can take a few minutes to be applied, as it requires a Tasklist restart.

Additionally, though this is not the PR scope, I would change the previous sentence as follows:

User task access restrictions are enabled by default. To disable them, navigate to Console settings and turn off the Enforce user task restrictions toggle.

☝️ @nathansandi, please see this feedback. Based on the current wording in the PR, I cannot approve.

@nathansandi
Copy link
Contributor Author

@mesellings @akeller thanks for the reviews :) Just made the suggested updates

@akeller akeller enabled auto-merge (squash) August 13, 2024 20:59
@akeller akeller merged commit 4b40320 into main Aug 13, 2024
7 checks passed
@akeller akeller deleted the add-disclaimer-on-user-task-restrictions-section branch August 13, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tasklist Issues related with Tasklist project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants