Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SM top-nav CSS #4122

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Remove SM top-nav CSS #4122

merged 1 commit into from
Aug 7, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented Aug 7, 2024

Description

When the Self-Managed icon was removed from the top nav (I couldn't find the PR for it 😞), the CSS remained, creating a visually odd experience. An area of the Self-Managed docs also randomly picked up the styles.

Thanks for the nudge @Sijoma!

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Changes to docs infra, including updates to workflows and adding new npm packages, must be first discussed via issue or #ask-c8-documentation and linked for context.

@akeller akeller added component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team labels Aug 7, 2024
@akeller akeller self-assigned this Aug 7, 2024
Copy link
Contributor

@Sijoma Sijoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing CSS by removing it. That's how it always works.

@akeller akeller merged commit 75fc1ab into main Aug 7, 2024
12 checks passed
@akeller akeller deleted the remove-SM-styles branch August 7, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants