Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Ingress content #4115

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Reorganize Ingress content #4115

merged 2 commits into from
Aug 8, 2024

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Aug 6, 2024

Description

Relates to https://github.com/camunda/developer-experience/issues/199

A quick win for cleaning up some of this content is to add tabs to the combined/separated Ingress instructions. Holding off on any additional content rework and the potential for creating new pages (instead of tabs) is separated out into https://github.com/camunda/developer-experience/issues/367.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark added dx Documentation infrastructure typically handled by the Camunda DX team deploy Stand up a temporary docs site with this PR labels Aug 6, 2024
@conceptualshark conceptualshark self-assigned this Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@conceptualshark conceptualshark added the component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed label Aug 6, 2024
@conceptualshark conceptualshark changed the title example of tabbed Ingress content Reorganize Ingress content Aug 6, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs August 6, 2024 20:59 Destroyed
@conceptualshark conceptualshark requested a review from a team August 8, 2024 18:00
@conceptualshark conceptualshark marked this pull request as ready for review August 8, 2024 18:01
@github-actions github-actions bot temporarily deployed to camunda-docs August 8, 2024 18:05 Destroyed
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick win, quick approval 🚀

@conceptualshark conceptualshark merged commit 53b2188 into main Aug 8, 2024
9 checks passed
@conceptualshark conceptualshark deleted the cg-tabbed-ingress-page branch August 8, 2024 19:04
Copy link
Contributor

github-actions bot commented Aug 8, 2024

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed deploy Stand up a temporary docs site with this PR dx Documentation infrastructure typically handled by the Camunda DX team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants