Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added ES,OS versions to announcement #4110

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

igpetrov
Copy link
Contributor

@igpetrov igpetrov commented Aug 6, 2024

Description

docs: added ES,OS versions to announcement

When should this change go live?

Hi team, sorry for urgency, we missed this announcement and would like to release it rather earlier. If possible, this week or early next week would do the trick. Thank you!

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@igpetrov igpetrov self-assigned this Aug 6, 2024
@igpetrov igpetrov added the component:zeebe Issues related with Zeebe project label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/reference/announcements.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@igpetrov igpetrov requested a review from a team August 6, 2024 16:06
@mesellings mesellings self-requested a review August 7, 2024 13:57
@igpetrov igpetrov merged commit 0f7f864 into main Aug 7, 2024
13 checks passed
@igpetrov igpetrov deleted the add-es-os-announcement-to-8.6 branch August 7, 2024 13:57
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igpetrov @conceptualshark I notice we call it "AWS OpenSearch" here, but have previously called it "Amazon OpenSearch", which AFAIK is the correct name: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/what-is.html

I haven't modified the file, but can do if you agree?

@igpetrov
Copy link
Contributor Author

igpetrov commented Aug 7, 2024

Hi @mesellings

Sorry, I didn't see that you were also reviewing. I would actually remove AWS at all (without adding Amazon).

@mesellings
Copy link
Contributor

Hi @mesellings

Sorry, I didn't see that you were also reviewing. I would actually remove AWS at all (without adding Amazon).

No problem - I must have commented just as it was merged! I suppose we do say Amazon OpenSearch in the docs already though, so perhaps better to be explicit for consistency ? e.g. https://docs.camunda.io/docs/next/self-managed/setup/guides/using-existing-opensearch/

@igpetrov
Copy link
Contributor Author

igpetrov commented Aug 7, 2024

Hi @mesellings
Sorry, I didn't see that you were also reviewing. I would actually remove AWS at all (without adding Amazon).

No problem - I must have commented just as it was merged! I suppose we do say Amazon OpenSearch in the docs already though, so perhaps better to be explicit for consistency ? e.g. https://docs.camunda.io/docs/next/self-managed/setup/guides/using-existing-opensearch/

Strongly supportive for consistency. Do you want me to change it?

@mesellings
Copy link
Contributor

Hi @mesellings
Sorry, I didn't see that you were also reviewing. I would actually remove AWS at all (without adding Amazon).

No problem - I must have commented just as it was merged! I suppose we do say Amazon OpenSearch in the docs already though, so perhaps better to be explicit for consistency ? e.g. https://docs.camunda.io/docs/next/self-managed/setup/guides/using-existing-opensearch/

Strongly supportive for consistency. Do you want me to change it?

I would go ahead and change it thanks @igpetrov, unless @conceptualshark feels strongly that we should remove it?

@conceptualshark
Copy link
Contributor

Consistency works for me here. 👍 Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:zeebe Issues related with Zeebe project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants