-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added ES,OS versions to announcement #4110
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igpetrov @conceptualshark I notice we call it "AWS OpenSearch" here, but have previously called it "Amazon OpenSearch", which AFAIK is the correct name: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/what-is.html
I haven't modified the file, but can do if you agree?
Hi @mesellings Sorry, I didn't see that you were also reviewing. I would actually remove AWS at all (without adding Amazon). |
No problem - I must have commented just as it was merged! I suppose we do say Amazon OpenSearch in the docs already though, so perhaps better to be explicit for consistency ? e.g. https://docs.camunda.io/docs/next/self-managed/setup/guides/using-existing-opensearch/ |
Strongly supportive for consistency. Do you want me to change it? |
I would go ahead and change it thanks @igpetrov, unless @conceptualshark feels strongly that we should remove it? |
Consistency works for me here. 👍 Thanks for the catch! |
Description
docs: added ES,OS versions to announcement
When should this change go live?
Hi team, sorry for urgency, we missed this announcement and would like to release it rather earlier. If possible, this week or early next week would do the trick. Thank you!
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).