Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include warning about console and OIDC not being supported together #4099

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

jessesimpson36
Copy link
Contributor

@jessesimpson36 jessesimpson36 commented Aug 2, 2024

Description

Console + OIDC is not supported together until v8.6. This docs update will add a mention of this into our Announcements section of our docs.

2024-08-02-110446_grim

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Aug 2, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@jessesimpson36 jessesimpson36 requested review from a team and removed request for christinaausley August 2, 2024 15:10
@akeller akeller added the component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed label Aug 2, 2024
@akeller akeller added the component:console Issues related with Console project label Aug 2, 2024
@akeller
Copy link
Member

akeller commented Aug 5, 2024

@theburi can you review this change? I also see the public issue has two alpha labels - is that correct? If so, this is good to merge.

@jessesimpson36
Copy link
Contributor Author

@akeller I see from this comment:
https://github.com/camunda/product-hub/issues/2092#issuecomment-2227869728

that alpha3 does not support console SM and that this was pushed to alpha4. therefore, I will remove the alpha3 label from the public issue.

@jessesimpson36
Copy link
Contributor Author

Actually, @akeller , I see that one is target:alpha3 and the other is version:alpha4. I think perhaps there may be 2 different types of tags to track what a change was intended for vs. what made it in. could someone clarify?

@akeller
Copy link
Member

akeller commented Aug 6, 2024

Actually, @akeller , I see that one is target:alpha3 and the other is version:alpha4. I think perhaps there may be 2 different types of tags to track what a change was intended for vs. what made it in. could someone clarify?

@jessesimpson36 we are good. It had two target:alphaX at one point, but it seems to be sorted out now.

@akeller akeller merged commit 76cb20a into main Aug 6, 2024
7 checks passed
@akeller akeller deleted the jessesimpson36-warning-about-console-and-oidc branch August 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:console Issues related with Console project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants