Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(slack-documentation): update the documentation for slack connector #4096

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

mathias-vandaele
Copy link
Contributor

@mathias-vandaele mathias-vandaele commented Aug 2, 2024

update the documentation for slack connector, we can now use channel ID to invite users into channel

Description

camunda/connectors#2695

We can now invite new users into a channel using the Channel ID

It will be available in 8.6.0-alpha4-rc2 of connectors

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

…or, we can now use channel ID to invite users into channel
@mathias-vandaele mathias-vandaele added 8.6.0-alpha4 August 2024 alpha release hold This issue is parked, do not merge. labels Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/connectors/out-of-the-box-connectors/slack.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley added the component:connectors Issues related to the connectors project. label Aug 2, 2024
@christinaausley
Copy link
Contributor

@mathias-vandaele Just let @camunda/tech-writers know when you're ready for review 👍

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@christinaausley
Copy link
Contributor

@mathias-vandaele Do you want this to go out with the alpha tomorrow? If so, we'll likely need an engineering and technical writer review on this ASAP.

@akeller akeller requested review from a team and sbuettner August 12, 2024 22:14
@akeller
Copy link
Member

akeller commented Aug 12, 2024

Hello @mathias-vandaele - it's the end of my day here in the US, but it's not clear to me if this PR is ready to merge for the alpha release tomorrow. Please remove the hold label and ping us on ask-c8-documentation for a review, merge, and release. I've added @sbuettner as a reviewer as well, but feel free to add a different engineering reviewer.

@sbuettner sbuettner removed the hold This issue is parked, do not merge. label Aug 13, 2024
@mesellings
Copy link
Contributor

Hi @mathias-vandaele - is this PR ready to merge for the alpha release today please?

If so, please remove the hold label and ping us on ask-c8-documentation for a review, merge, and release, or Slack me directly. We've added @sbuettner as a reviewer as well, but feel free to add a different engineering reviewer.

@mathias-vandaele
Copy link
Contributor Author

Hi @mathias-vandaele - is this PR ready to merge for the alpha release today please?

If so, please remove the hold label and ping us on ask-c8-documentation for a review, merge, and release, or Slack me directly. We've added @sbuettner as a reviewer as well, but feel free to add a different engineering reviewer.

Hi @mesellings
It is ready to merge for the alpha released.
The hold label has been removed, I also sent a message in the ask-c8-documentation channel

@mesellings
Copy link
Contributor

Hi @mathias-vandaele thank you - I will perform a review for you and we can get it merged today 👍

@mesellings mesellings self-requested a review August 13, 2024 08:23
@mesellings mesellings self-assigned this Aug 13, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathias-vandaele LGTM, I made a few edits as some ordered lists should be bullet lists, and tidied up a few sentence fragments. Approved 👍

@mathias-vandaele mathias-vandaele merged commit 154521e into main Aug 13, 2024
7 checks passed
@mathias-vandaele mathias-vandaele deleted the 2695-add-option-invite-by-channel-id branch August 13, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0-alpha4 August 2024 alpha release component:connectors Issues related to the connectors project.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants