Exporter metrics with Micrometer #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
christinaausley
added
the
component:self-managed
|
Is this relevant to the current |
No it is not it will be in 8.6 |
christinaausley
approved these changes
Jul 31, 2024
npepinpe
reviewed
Aug 2, 2024
| @@ -64,6 +64,12 @@ validation of their configuration (e.g. fail if missing arguments). For this val | |||
| One caveat is that an instance of an exporter is created and immediately thrown away. Therefore, exporters should not perform any computationally | |||
| heavy work during instantiation/configuration. | |||
|
|
|||
| ### Metrics | |||
|
|
|||
| The exporter is provided with a Micrometer [MeterRegistry](https://docs.micrometer.io/micrometer/reference/concepts/registry.html) in the `Exporter#configure(Configuration)` method through the configuration. Any metrics to be exported should interact with the registry. | |||
There was a problem hiding this comment.
❌ This is actually Exporter#configure(Context) 🙃
There was a problem hiding this comment.
I'll launch a PR with this fix 👍
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tells the user how to aadd metrics to their exporter and notes a potential pitfall about interacting with a to be discarded registry.
When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).