-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unify API Auth docs (Admin, Camunda 8, and Web Modeler APIs) #4078
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
I'm seeking early feedback on these changes. I may decide to introduce per API incrementally instead of all at once. Some open questions I have:
|
@pepopowitz see #4071 and the linked Slack convo for updates to the "deprecated APIs" |
Note to me (and anyone looking on) that I am ready to acknowledge that the scope of this PR has become too large, and is in danger of living a long time. Next week I plan to move the tracking of all different auth guides into the linked issue, so that this PR becomes one of many that can be merged incrementally. |
Hello friends, this PR is ready for review. When the preview site completes deployment, you can find the updated auth guides at:
|
docs/apis-tools/camunda-api-rest/camunda-api-rest-authentication.md
Outdated
Show resolved
Hide resolved
…sole (administration)
…sole (camunda-api)
docs/apis-tools/camunda-api-rest/camunda-api-rest-authentication.md
Outdated
Show resolved
Hide resolved
"clusterSize": 3, | ||
"partitionsCount": 3, | ||
"replicationFactor": 3, | ||
"gatewayVersion": "8.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea - Could be fancy here and get a variable for the product version 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, in general I didn't feel great about these sample API responses. I want to show enough that it's useful, but not so much that people get lost in the details or it's drifting from the real response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my comments on #4152, I see it as a bonus to sync the tabs down the page and wasn't sure if we need to note anything about the token expiration.
I didn't mention this outside of my comment about the product version, but I did see a couple of places where we reference a "version" that I worry will be out of date, certainly at minors but potentially at other points. I don't think this is a huge risk because these references are in example json.
All of this to say, ✅ 🚀
This PR is ready for a final review, with all required feedback addressed, and backported to v8.5 (there is no Camunda REST API in version 8.5, so that one was not backported). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking feedback, but this did prompt me to realize we don't have anything in the docs about the Zeebe API moving to the Camunda 8 API. That is out of scope of this PR and I will follow up separately.
🧹 Preview environment for this PR has been torn down. |
Description
Part of #4117.
Unifies the content on our various API Authentication docs, so that each API Auth guide contains the following:
APIs included in this PR
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).