-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(web modeler): add feature documentation for git sync #4073
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Adding @JacobiCamunda so he can give his BE engineer point of view regarding possible errors and known limitations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to read! 🚀
I reviewed from the backend perspective for the current implementation. I will add another review if necessary when the push operation is fully integrated.
CC: @marcellobarile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔝 very nicely done! Thanks!
@conceptualshark there is a small change in the settings dialog; The issue for this change: Excuse us for the last-minute change :) I hope that's fine. FYI @JacobiCamunda |
@marcellobarile, a part would be good to say that actions which alters the commit sha which Web Modeler is currently synced to (like a squash) in the remote branch could break the git sync. |
@conceptualshark this morning we have acknowledged that timeouts during the sync operations might occur (we don't know how often yet). Is it worth mentioning this in the known limitations? the only thing that the user could to so far is retrying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
just touching base, is there any review still pending here? |
@marcellobarile I believe we're good to go - just let me know if it can be merged now (and if you'd like a docs release at any point). Otherwise, I can put a |
@conceptualshark thanks for the update! It's good to know that the doc is ready, just put it on hold because we are still about to kick-off the QA. |
Popping in to say I LOVE that the docs were drafted ahead of QA! Having them available means QA can provide feedback on the docs experience as part of the overall epic experience. Great job! 🧡 |
@conceptualshark the feature has been merged to the main branch and will be released on SaaS tomorrow. Ping me once your release is done so we can orchestrate ours. |
@marcellobarile The docs should now be live: https://docs.camunda.io/docs/next/components/modeler/web-modeler/git-sync/ |
Description
Resolves https://github.com/camunda/web-modeler/issues/9706, feature documentation for Git Sync (GitHub only).
Related to https://github.com/camunda/product-hub/issues/2036
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).