Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(web modeler): add feature documentation for git sync #4073

Merged
merged 13 commits into from
Aug 7, 2024

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Jul 26, 2024

Description

Resolves https://github.com/camunda/web-modeler/issues/9706, feature documentation for Git Sync (GitHub only).

Related to https://github.com/camunda/product-hub/issues/2036

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark added component:docs Documentation improvements, including new or updated content component:web-modeler-SaaS Continuous delivery - Issues related with Web Modeler SaaS component:web-modeler-sm Issues related with Web Modeler Self-Managed 8.6.0-alpha4 August 2024 alpha release labels Jul 26, 2024
@conceptualshark conceptualshark self-assigned this Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/modeler/web-modeler/git-sync.md
  • docs/components/modeler/web-modeler/img/git-sync.png

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@marcellobarile
Copy link
Contributor

Adding @JacobiCamunda so he can give his BE engineer point of view regarding possible errors and known limitations.

Copy link
Contributor

@JacobiCamunda JacobiCamunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to read! 🚀
I reviewed from the backend perspective for the current implementation. I will add another review if necessary when the push operation is fully integrated.

CC: @marcellobarile

docs/components/modeler/web-modeler/git-sync.md Outdated Show resolved Hide resolved
docs/components/modeler/web-modeler/git-sync.md Outdated Show resolved Hide resolved
docs/components/modeler/web-modeler/git-sync.md Outdated Show resolved Hide resolved
marcellobarile
marcellobarile previously approved these changes Jul 29, 2024
Copy link
Contributor

@marcellobarile marcellobarile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝 very nicely done! Thanks!

docs/components/modeler/web-modeler/git-sync.md Outdated Show resolved Hide resolved
docs/components/modeler/web-modeler/git-sync.md Outdated Show resolved Hide resolved
docs/components/modeler/web-modeler/git-sync.md Outdated Show resolved Hide resolved
docs/components/modeler/web-modeler/git-sync.md Outdated Show resolved Hide resolved
@marcellobarile
Copy link
Contributor

marcellobarile commented Jul 31, 2024

@conceptualshark there is a small change in the settings dialog;
We are replacing Application ID and Owner name with Installation ID and Client ID.
The Installation ID can be retrieved as explained here
From a role perspective, the nature of these two fields does not change from the previous implementation.

The new UI:
image

The issue for this change:
https://github.com/camunda/web-modeler/issues/10302

Excuse us for the last-minute change :) I hope that's fine.

FYI @JacobiCamunda

@JacobiCamunda
Copy link
Contributor

@marcellobarile, a part would be good to say that actions which alters the commit sha which Web Modeler is currently synced to (like a squash) in the remote branch could break the git sync.

@marcellobarile
Copy link
Contributor

@conceptualshark this morning we have acknowledged that timeouts during the sync operations might occur (we don't know how often yet). Is it worth mentioning this in the known limitations? the only thing that the user could to so far is retrying.

Copy link
Contributor

@marcellobarile marcellobarile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcellobarile
Copy link
Contributor

just touching base, is there any review still pending here?

@conceptualshark
Copy link
Contributor Author

@marcellobarile I believe we're good to go - just let me know if it can be merged now (and if you'd like a docs release at any point). Otherwise, I can put a hold label on it until you're ready.

@marcellobarile
Copy link
Contributor

@conceptualshark thanks for the update! It's good to know that the doc is ready, just put it on hold because we are still about to kick-off the QA.
Let's merge this in the context of the next release. I'll keep you posted when ready.

@marcellobarile marcellobarile added the hold This issue is parked, do not merge. label Aug 5, 2024
@akeller
Copy link
Member

akeller commented Aug 5, 2024

@conceptualshark thanks for the update! It's good to know that the doc is ready, just put it on hold because we are still about to kick-off the QA. Let's merge this in the context of the next release. I'll keep you posted when ready.

Popping in to say I LOVE that the docs were drafted ahead of QA! Having them available means QA can provide feedback on the docs experience as part of the overall epic experience. Great job! 🧡

@marcellobarile marcellobarile removed the hold This issue is parked, do not merge. label Aug 7, 2024
@marcellobarile
Copy link
Contributor

@conceptualshark the feature has been merged to the main branch and will be released on SaaS tomorrow. Ping me once your release is done so we can orchestrate ours.

@conceptualshark conceptualshark merged commit b127166 into main Aug 7, 2024
8 of 9 checks passed
@conceptualshark conceptualshark deleted the cg-gitsync-docs branch August 7, 2024 15:41
@conceptualshark
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0-alpha4 August 2024 alpha release component:docs Documentation improvements, including new or updated content component:web-modeler-SaaS Continuous delivery - Issues related with Web Modeler SaaS component:web-modeler-sm Issues related with Web Modeler Self-Managed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants