Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spring zeebe guide #4072

Merged
merged 4 commits into from
Aug 2, 2024
Merged

update spring zeebe guide #4072

merged 4 commits into from
Aug 2, 2024

Conversation

christinaausley
Copy link
Contributor

Description

Minor adjustments to spring guide -- closes https://github.com/camunda/developer-experience/issues/337.

To merge after #4067 -- @pepopowitz I'll resolve any merge conflicts here.

To backport upon approval. Additional changes to be made in https://github.com/camunda/camunda-8-get-started-spring and synchronized with docs release.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added component:docs Documentation improvements, including new or updated content e2e E2E docs getting started project labels Jul 26, 2024
@christinaausley christinaausley self-assigned this Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes, thanks for updating!

docs/guides/getting-started-java-spring.md Outdated Show resolved Hide resolved
docs/guides/getting-started-java-spring.md Show resolved Hide resolved
@christinaausley
Copy link
Contributor Author

@pepopowitz This is cleaned up based on your comments, with mirrored changes in camunda/camunda-8-get-started-spring#5.

@akeller akeller added the deploy Stand up a temporary docs site with this PR label Jul 30, 2024
@christinaausley christinaausley requested a review from akeller July 31, 2024 12:48
@github-actions github-actions bot temporarily deployed to camunda-docs July 31, 2024 13:03 Destroyed
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - I did not have time to run this for 8.5 or the current alpha, so the review I'm providing is a bit handwavy.

@christinaausley christinaausley merged commit deeb4d5 into main Aug 2, 2024
8 checks passed
@christinaausley christinaausley deleted the update-spring-guide branch August 2, 2024 17:40
Copy link
Contributor

github-actions bot commented Aug 2, 2024

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR e2e E2E docs getting started project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants