Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backups.md #4069

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Update backups.md #4069

merged 4 commits into from
Jul 26, 2024

Conversation

felix-mueller
Copy link
Member

@felix-mueller felix-mueller commented Jul 26, 2024

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@felix-mueller felix-mueller requested a review from Sijoma July 26, 2024 09:55
Copy link
Contributor

github-actions bot commented Jul 26, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

Sijoma
Sijoma previously approved these changes Jul 26, 2024
Copy link
Contributor

@Sijoma Sijoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this also need to go to the versioned_docs?

@akeller akeller enabled auto-merge (squash) July 26, 2024 14:43
@akeller akeller requested a review from Sijoma July 26, 2024 14:43
Sijoma
Sijoma previously approved these changes Jul 26, 2024
Copy link
Contributor

@Sijoma Sijoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! @akeller that was true speedboat style.

@akeller akeller merged commit 6766183 into main Jul 26, 2024
7 checks passed
@akeller akeller deleted the hourly-backups branch July 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants