chore(preview-envs): Look into improving commenting of preview enviro… #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andromaqui
added
deploy
andromaqui
force-pushed
the
improve-commenting
branch
from
2f4e992 to
d753783
Compare
|
@andromaqui can you add some details to the body of this PR, to explain how you're looking to improve the comments? |
|
@andromaqui
I marked all spots via PR commentary. |
kellervater
requested changes
Jul 24, 2024
andromaqui
requested review from
kellervater
and removed request for
kellervater
kellervater
approved these changes
Jul 25, 2024
|
🧹 Preview environment for this PR has been torn down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nments
Description
This pr aims to switch to a different action in order to post comments in prs called
mshick/add-pr-comment. The newlyused action has the capability of always positioning the newly created comment in the latest comment position and requires very minimal configuration in order to find old comments.
When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).TEST
Test 1: Sequential deployments dont create a new group of messages
Tested with this commit by making a new push after there had already been a comment for the previous deployment
Test 2: Triggering the teardown workflow updates the preview-env-status comments
Tested with this commit by adding and removing the deploy label