Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spring support policy #4052

Merged
merged 4 commits into from
Aug 6, 2024
Merged

add spring support policy #4052

merged 4 commits into from
Aug 6, 2024

Conversation

christinaausley
Copy link
Contributor

Description

Related to #4036.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added the component:docs Documentation improvements, including new or updated content label Jul 19, 2024
@christinaausley christinaausley self-assigned this Jul 19, 2024
Copy link
Contributor

github-actions bot commented Jul 19, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley
Copy link
Contributor Author

@felix-mueller @megglos I assume this should also be backported to 8.5? Ideally I'd like a statement/example that we don't need to change for every version of the docs. Would it be sufficient to just say "For new minor releases, Camunda typically automatically updates to new minor releases of our dependencies when they are released. This general rule also applies to Spring."?

If not, I may revisit some of the phrasing here, unless we want to default to a specific version comparison with 8.5, for example.

Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reference clients on the supported environment page, but don't include the Spring SDK.

I don't love the phrasing here and have concerns similar to @christinaausley's comment about changing this for every new version. We can be more definitive here and update the table per minor version but also consider moving this content to the supported environment page, a page we already know changes for each minor.

@felix-mueller
Copy link
Member

@akeller @christinaausley - from my perspective we can be more generic, my message was just an example for 8.6.
we can also add spring sdk to supported environments and link back to the version matrix (similar to helm cli).
let's keep the statement itself spring specific for now since it might have more implications and i dont see the need to go through it right now.

@christinaausley
Copy link
Contributor Author

@felix-mueller I think I'm following correctly here -- let me know based on my latest changes.

@felix-mueller
Copy link
Member

@christinaausley lgtm

@christinaausley
Copy link
Contributor Author

@akeller Can I get one final review from you here? 😄

@christinaausley christinaausley merged commit 537e223 into main Aug 6, 2024
7 checks passed
@christinaausley christinaausley deleted the add-spring-support-policy branch August 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants