-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs landing page urgent tweaks #4034
Conversation
I have added the new |
Your preview env has been torn down. |
Is this something we are trying to urgently merge in? I was planning to solicit feedback this week as @PhilippaC22 and I get started on a formal second iteration, but thought these changes were rushed specifically for today. |
You should still get quick feedback on urgent changes, but at a certain point you can stop accepting feedback and document that you will move forward and iterate in the future. Particularly in this case, since you are making UX/UI changes and are open to suggestions, we should make it easy to see the changes. |
Well... I thought the preview site would be great, but it looks like it's on an old commit. When running locally, these are the changes I see (and the UX problem where the button/box isn't entirely clickable is fixed!): Screen.Recording.2024-07-16.at.2.45.20.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX issue appears to be addressed, the whole box is clickable!
Description
Adjusts card links and coloring -- open to suggestions, but this is an urgent patch fix.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).