-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES exporter to application.yaml #4031
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
For reviewers (@christinaausley @conceptualshark @pepopowitz)- I'm looking for the following, feedback-wise:
Please set aside some time to run this on your local machine or work together to see how it runs. Let's set a deadline to do this by next Friday (July 26). This is a high priority (part of the getting started experience), but not urgent. If the urgency increases, I'll move forward as-is and open a new PR based on your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my feedback is non-blocking, but one in particular (marked "blocking") is preventing me from moving forward to test this out. I am not clear on which specific settings I need to change for elasticsearch.
3. Start Elasticsearch by running `ELASTICSEARCH_HOME/bin/elasticsearch` (or `ELASTICSEARCH_HOME\bin\elasticsearch.bat` on Windows). | ||
|
||
### Download and configure Camunda | ||
|
||
1. Download the [latest release artifact](https://github.com/camunda/camunda/releases), starting with [8.6.0-alpha2](https://github.com/camunda/camunda/releases/tag/8.6.0-alpha2). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running alpha2 seemed to result in a version mismatch for me, but running alpha3 went fine:
io.camunda.operate.schema.SchemaStartup - Schema startup failed: Error(s) in index schema: Newer version(s) for operation (8.4.0) already exists: [8.4.1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romansmirnov thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumption: The same ES instance has been used, but first, alpha3 was started, creating an index in version 8.4.1, and then alpha2 was started, expecting the index to be in version 8.4.0.
Can you please confirm my understanding? If so, I don't recommend using the same ES instance and switching from a newer C8 version to an older C8 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@conceptualshark I don't know if we should expect people using the same ES instance (purposefully or accidentally). Can I give you a follow up here to maybe add a small troubleshooting section or think more about this experience for new users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I can think of that would have impacted this is having started C8SM Run on this machine (it was not running at the time). When I tested this PR, I ran ES + alpha2, failed with the above error, stopped both, then reinstalled and ran ES + alpha3, so I am not sure why an index (or even ES instance) would have been maintained.
Unfortunately, I can't add anything for resolving it, because it still doesn't work on my machine (I had to run it in a VM).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a second pass. As I was finishing, I noticed in Slack that I may have been asked to use alpha3, but I went through with alpha2. Oops? This might be a worthless review.
In the end, I can see a login screen for operate at localhost:8080 (though I don't know what credentials to log in with). I see localhost:8080/tasklist trying to serve something, but it's basically a blank gray page. I am wondering if it would serve an actual tasklist if I had logged into localhost:8080.
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
I ran through this whole process in UTM to isolate it from the build errors I was having on my machine and: success! I changed the ES security config My assumption is testing the C8Run script caused some versioning/config issues there, which might just be good to have in mind if we end up with folks attempting multiple methods of installing/running. |
I don't love this, because users will only scroll so far down a page in general, and it can make the page a bit messy. Are we able to link to it, or include it in something like a If not, is there a specific reason why users aren't able to find these details in elements like these already? Fun fact, I guess you can use
Some details here.
|
Hi All - thanks for the reviews and feedback. I will do one more pass today to close this out. Related, we will swap in C8SM Run to be our single option for getting started with SM. If you have more input on that part of the conversation, please go to #e2e-docs-experience-getting-started-guides. Regardless, it's important if we do ever need to have both of these, we can easily pull these changes back in and offer parallel paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is in good shape! If we're eager to merge, my suggestion isn't blocking.
Co-authored-by: Cole Isaac <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Description
Open discussion - https://camunda.slack.com/archives/C074T8BTTM2/p1721078565460779?thread_ts=1720034668.231519&cid=C074T8BTTM2
Takes the following instructions, packaged with the release artifacts, and makes them more consumable:
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).