-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported-environments.md #4010
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Hi @igpetrov, see request from Tobias to update the docs. Are we already confident with that OS bump? |
Hi @MaxTru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am thinking whether it makes sense to call out 2.9.x+
instead of 2.9; 2.11; 2.13+
which sounds the same to me? Also, was there any agreement that we start from 2.9?
Hello @igpetrov,
As the minor versions are upward compatible, "x.+," it is better for customers to support older versions as they are not forced to upgrade. Engineering requested changing to 2.9+ to use new features and reduce test efforts. Regards Tobias |
Hi @christinaausley @toco-cam, Can we merge this one? Let's give the Customers as much time as we can to discover this. Thank you! |
@igpetrov, I added @camunda/tech-writers as reviewers so we can merge this. I also updated the PR description based on what I see changed in the PR - no backporting required as this change is just for |
That's correct, it's for |
Igor suggested:
We had a brief call, and as we do not have dedicated test coverage for the different versions 2.9, 2.11, and 2.13, there is, IMO no value in calling them out specifically. WDYT? |
I agree. Let's go for |
@christinaausley based on this comment, can you adjust this PR for @toco-cam so we can get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @akeller 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the convo in this PR, I believe this reflects the intended change - approving.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
e9af67f
to
eb580ab
Compare
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).