Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(self-managed): eks upgrade module doc #4004

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Jul 1, 2024

Description

This PR aims to document the upgrade process for the AWS EKS TF module, specifically addressing the major version bump of the EKS module that we are incorporating. It includes updating our AWS documentation to reflect the necessary changes and instructions for users during the upgrade process.

When should this change go live?

  • This is part of a scheduled alpha or minor. (apply alpha or minor label)

PR Checklist

  • My changes are for the next minor and are in /docs directory (aka /next/).
  • My changes require an Engineering review, and I've assigned the Engineering DRI or delegate.
  • My changes require a technical writer review, and I've assigned @camunda/tech-writers as a reviewer.

@leiicamundi leiicamundi added hold This issue is parked, do not merge. component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Jul 1, 2024
@leiicamundi leiicamundi requested a review from Langleu July 4, 2024 07:27
@leiicamundi leiicamundi requested a review from a team July 4, 2024 07:33
@leiicamundi leiicamundi marked this pull request as ready for review July 4, 2024 07:34
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks quite good, I like the references to the official docs to keep it simple on our side.

@leiicamundi leiicamundi force-pushed the feature/update-eks-setup branch from acc5920 to a5c9b70 Compare July 4, 2024 10:02
@leiicamundi
Copy link
Contributor Author

Thanks for the review @Langleu, I've fixed all the issues spotted

@leiicamundi leiicamundi requested a review from Langleu July 4, 2024 10:08
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't add comments for all versions but applies to the other ones as well about the source reference

Langleu
Langleu previously approved these changes Jul 4, 2024
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side.

@leiicamundi leiicamundi removed the hold This issue is parked, do not merge. label Jul 4, 2024
christinaausley
christinaausley previously approved these changes Jul 5, 2024
@christinaausley
Copy link
Contributor

@leiicamundi Can we go ahead and merge, or do you have additional changes coming?

@leiicamundi
Copy link
Contributor Author

Hey @christinaausley, please wait until a patch is published on the EKS terraform module, then we will be good to merge it ;)

@leiicamundi leiicamundi dismissed stale reviews from christinaausley and Langleu via d744152 July 16, 2024 15:52
@leiicamundi leiicamundi enabled auto-merge (squash) July 17, 2024 12:48
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release version was updated 👍

@leiicamundi leiicamundi merged commit e8969de into main Jul 17, 2024
7 checks passed
@leiicamundi leiicamundi deleted the feature/update-eks-setup branch July 17, 2024 13:04
@akeller
Copy link
Member

akeller commented Jul 17, 2024

Since the description does not include any info about when to release this change, it will sit in the queue until something with priority must be released. If that's not your intention and you'd like a docs release sooner, please reach out on #ask-c8-documentation.

@Langleu
Copy link
Member

Langleu commented Jul 18, 2024

thanks @akeller, the change didn't have a strict priority.
As with most Infrastructure, it's decapsulated from the actual software development. So, we're generally good with the docs release cycle.
Thanks for the heads up if we have something important in the future 🙇.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants