-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(self-managed): eks upgrade module doc #4004
Conversation
docs/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
docs/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
docs/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
...8.4/self-managed/platform-deployment/helm-kubernetes/platforms/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
...8.4/self-managed/platform-deployment/helm-kubernetes/platforms/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
docs/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
...8.4/self-managed/platform-deployment/helm-kubernetes/platforms/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.5/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.5/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.5/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks quite good, I like the references to the official docs to keep it simple on our side.
acc5920
to
a5c9b70
Compare
Thanks for the review @Langleu, I've fixed all the issues spotted |
docs/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
docs/self-managed/setup/deploy/amazon/amazon-eks/terraform-setup.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't add comments for all versions but applies to the other ones as well about the source reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my side.
@leiicamundi Can we go ahead and merge, or do you have additional changes coming? |
Hey @christinaausley, please wait until a patch is published on the EKS terraform module, then we will be good to merge it ;) |
d744152
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release version was updated 👍
Since the description does not include any info about when to release this change, it will sit in the queue until something with priority must be released. If that's not your intention and you'd like a docs release sooner, please reach out on #ask-c8-documentation. |
thanks @akeller, the change didn't have a strict priority. |
Description
This PR aims to document the upgrade process for the AWS EKS TF module, specifically addressing the major version bump of the EKS module that we are incorporating. It includes updating our AWS documentation to reflect the necessary changes and instructions for users during the upgrade process.
When should this change go live?
PR Checklist
/docs
directory (aka/next/
).