Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector task react component #3980

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Conversation

christinaausley
Copy link
Contributor

Description

Related to https://github.com/camunda/team-connectors/issues/805.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added hold This issue is parked, do not merge. component:connectors Issues related to the connectors project. labels Jun 25, 2024
@christinaausley christinaausley self-assigned this Jun 25, 2024
Copy link
Contributor

github-actions bot commented Jun 25, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/connectors/out-of-the-box-connectors/amazon-sagemaker.md
  • docs/components/connectors/out-of-the-box-connectors/sql.md
  • docs/components/connectors/use-connectors/outbound.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley
Copy link
Contributor Author

@YanaSegal Upon approval, I'll add this to all references across the docs. I assume this should be backported all the way through?

@YanaSegal
Copy link
Contributor

Hi, it looks good, but the image is not the best (I know I provided it🙈 attaching here a new image.
@johnBgood wdyt, is the image better now?

coonector task

@johnBgood
Copy link
Contributor

@YanaSegal it looks great! :)

Copy link
Contributor

@YanaSegal YanaSegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, i provided a better image for use in this section:
#3980 (comment)

thanks!

@christinaausley
Copy link
Contributor Author

christinaausley commented Jun 28, 2024

@YanaSegal I'll add this screenshot, and adjust all of the references across the docs. Should this be backported all the way through? If I can't get to this today, I'll have it done next week 👍

@YanaSegal
Copy link
Contributor

YanaSegal commented Jun 28, 2024

@christinaausley, since the new context pad went out for most in 8.5, we can update the docs from this version. Otherwise, for older versions, they still need to use the old "wrench" icon.

@christinaausley
Copy link
Contributor Author

@YanaSegal @johnBgood this is ready for final review 👍

@johnBgood
Copy link
Contributor

@christinaausley I checked http://localhost:3000/docs/components/connectors/out-of-the-box-connectors/slack/ locally but I think the paths are broken, or did I miss something?
The section is empty:

Screenshot 2024-07-01 at 09 26 48

Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

@christinaausley christinaausley removed the hold This issue is parked, do not merge. label Jul 1, 2024
@christinaausley christinaausley merged commit f99e5d1 into main Jul 1, 2024
8 of 9 checks passed
@christinaausley christinaausley deleted the connector-task-react-component branch July 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants