-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(preview-envs): Build workflows to deploy and tear down preview … #3947
Conversation
Your preview env has been teared down. |
I'm not sure if you're ready for a review from us at DX, but here are some things I noticed:
|
with: | ||
comment-id: ${{ steps.find-comment.outputs.comment-id }} | ||
body: | | ||
Your preview env has been teared down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your preview env has been teared down. | |
Your preview env has been torn down. |
Your preview env has been torn down. |
@pepopowitz Thank you for bringing these observations to my attention. Here is a few things which came out of my investigation:
My overall feeling is that either there is an actual underlying problem or I might have messed up the workflow runs somehow since I was running a lot of tests in parallel. I will continue testing this today. |
Preview environment has successfully been deployed. You can access it on https://preview.docs.camunda.cloud/pr-3947/index.html. |
Preview environment has successfully been deployed. You can access it on https://preview.docs.camunda.cloud/pr-3947/index.html. |
…envs
Description
This pr aims to add the following functionality:
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).NOTES:
preview-env-deploy
workflow is set to timeout in 30 mins because some builds took a bit more than 20 mins. I thought it might make sense to not have the timeout too tightpreview-env-deploy
in theBuild
step, I tried passing the bucket name prepended by https:// to node but node couldnt read it for some reason:DOCS_SITE_URL: https://${{ steps.secrets.outputs.PREVIEW_ENV_BUCKET_NAME }}
The only logical explanation I could think of is that there might an issue when one concatenates a string to a secret so I therefore did the processing in the
docausaurus.config.js
fileTESTING:
Test 1: Test that the preview env can be deployed and the link works when adding a label
Test 2: Test that the preview env gets cleaned up when removing the label
See the comment below which replaces the original comment with a new one indicating that the deployment has been cleaned up