Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(documentation): add info about missing secrets and clients in t… #3901

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

marcellobarile
Copy link
Contributor

…he web-modeler

Description

Introduces information about missing secrets and client credentials warnings shown in the web-modeler at the deploy or run phase.

Related to https://github.com/camunda/web-modeler/issues/8635

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@marcellobarile marcellobarile added hold This issue is parked, do not merge. component:web-modeler-SaaS Continuous delivery - Issues related with Web Modeler SaaS labels Jun 7, 2024
@marcellobarile marcellobarile self-assigned this Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/modeler/web-modeler/run-or-publish-your-process.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

HanselIdes
HanselIdes previously approved these changes Jun 7, 2024
Copy link
Contributor

@HanselIdes HanselIdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about "misconfigured" that should be cleaned up- otherwise LGTM

I'm pre-approving so you can merge it after you're happy with the docs change

@akeller akeller requested review from a team and removed request for akeller June 7, 2024 15:32
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammatical clean up in my latest commit 👍

@marcellobarile marcellobarile removed the hold This issue is parked, do not merge. label Jun 11, 2024
@marcellobarile marcellobarile enabled auto-merge (squash) June 11, 2024 09:09
@marcellobarile marcellobarile merged commit 304a231 into main Jun 11, 2024
6 checks passed
@marcellobarile marcellobarile deleted the add-missing-credentials-info branch June 11, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:web-modeler-SaaS Continuous delivery - Issues related with Web Modeler SaaS
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants