-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement pushfeedback #3837
implement pushfeedback #3837
Conversation
Since we have the Ask AI button, this is my preferred integration. Let's chat more on our internal devex channel about next steps @christinaausley. |
🟢 This gets my stamp of approval (and, for internal purposes, your line manager's stamp of approval). @christinaausley will work through the vendor/new tool process internally. Thanks for getting this rolling! |
This is ready for final review @pepopowitz @akeller 👍 |
Adding |
🧹 Preview environment for this PR has been torn down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!!!! Great work!!
The only blocking request I have is that we add some information about why we are swizzling this component. I also added some comments related to a non-blocking styling nit.
I will also mention that I was unable to submit feedback through the preview site, with a message from PushFeedback that it was coming from a URL that they didn't recognize. I assume this will all just work when we go live, submitting feedback from the docs.camunda.io URL.
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: Steven Hicks <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thank you @pepopowitz! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking concerns from me.
If possible, we may want to add stage.docs.camunda.io to the list of URLs PushFeedback allows so we can test this before it goes all the way live, but I'm also fine with testing in production and removing it if we see anything concerning. YOLO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ ❤️ ❤️
We can only set one domain per "project" with PushFeedback, so I'm going to ship this. If anything wonky pops up I'll backtrack and create a new project with the staging domain to test more thoroughly. |
Description
Option #2 for the PushFeedback widget -- relates to #355.
This option uses Swizzling to extend our footer, essentially:
And when a user clicks either the thumbs up or thumbs down they see:
This takes care of the location issues I was having in #3812, but I can't figure out how to customize the pop-up modal to adjust its coloring and such. Thoughts @pepopowitz?
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).