-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(self-managed): console byo oidc #3798
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@ultraschuppi @theburi Please have a look into the docs for BYO OIDC. From my point of view we don't need that much additional docs. There is already a guide about a different OIDC provider. The console sm implementation aligns with the global values described in the guide. |
I, for one, endorse piggybacking on existing docs instead of reinventing the wheel. |
@christinaausley Can you please have a final review on this PR? It's part of |
Should this be merged in for alpha-3 tomorrow? |
@christinaausley waiting for green lights from QA :) |
@christinaausley We finally got green lights from QA. The changes will be part of 8.6 alpha4 - can I just merge this one? |
Description
Guides
for Console.When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).