Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(self-managed): console byo oidc #3798

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Conversation

urbanisierung
Copy link
Member

@urbanisierung urbanisierung commented May 14, 2024

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/self-managed/console-deployment/configuration.md
  • docs/self-managed/setup/guides/connect-to-an-oidc-provider.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@urbanisierung urbanisierung added the target:8.6 Issues included in the 8.6 release label May 14, 2024
@urbanisierung
Copy link
Member Author

@ultraschuppi @theburi Please have a look into the docs for BYO OIDC. From my point of view we don't need that much additional docs. There is already a guide about a different OIDC provider.

The console sm implementation aligns with the global values described in the guide.

@christinaausley christinaausley added the component:console Issues related with Console project label May 14, 2024
@ultraschuppi
Copy link
Contributor

@ultraschuppi @theburi Please have a look into the docs for BYO OIDC. From my point of view we don't need that much additional docs. There is already a guide about a different OIDC provider.

The console sm implementation aligns with the global values described in the guide.

I, for one, endorse piggybacking on existing docs instead of reinventing the wheel.

theburi
theburi previously approved these changes May 15, 2024
@urbanisierung urbanisierung marked this pull request as ready for review May 15, 2024 11:47
@urbanisierung
Copy link
Member Author

@christinaausley Can you please have a final review on this PR? It's part of next and will be officially released with 8.6. Thanks!

@christinaausley
Copy link
Contributor

Should this be merged in for alpha-3 tomorrow?

@urbanisierung
Copy link
Member Author

Should this be merged in for alpha-3 tomorrow?

@christinaausley waiting for green lights from QA :)

@urbanisierung urbanisierung added the 8.6.0-alpha4 August 2024 alpha release label Jul 30, 2024
@urbanisierung
Copy link
Member Author

@christinaausley We finally got green lights from QA. The changes will be part of 8.6 alpha4 - can I just merge this one?

@christinaausley christinaausley merged commit c9ee0a2 into main Jul 30, 2024
9 checks passed
@christinaausley christinaausley deleted the console-sm-byo-oidc branch July 30, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0-alpha4 August 2024 alpha release component:console Issues related with Console project target:8.6 Issues included in the 8.6 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants