-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(sql-connector): Add the documentation for the new SQL Connector #3707
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a SQL Connector task
To use the SQL Connector in your process, either change the type of existing task by clicking on it and using the wrench-shaped Change type context menu icon, or create a new Connector task by using the Append Connector context menu....
we have a new context pad and the wrench icon doesn't exist there. and the link to "follow our guide..." is not explaining about applying a connector to a diagram.
Maybe this link will be better to point to:
http://localhost:3000/docs/next/components/modeler/web-modeler/new-context-pad/
I think that this context pad is an alpha feature, and we still have the wrench in the Desktop modeler. Moreover, all our OOTB connectors documentations have this section. |
Yeah, we'll need to update this if the UI has changed. A separate issue would be great 👍 |
docs/components/connectors/out-of-the-box-connectors/available-connectors-overview.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this still be backported all the way through the docs, and just merged/released closer to the release date?
It's not backported; Will need to be merged closer to the release data indeed :) |
@johnBgood Are you looking for a final review here before merging for release tomorrow, or are there additional changes you are planning to make? |
@christinaausley I updated the label, due to some random issues last week we decided to release this feature next month. So we can keep this PR open until then if that's ok. |
5f812e6
to
111466f
Compare
Description
Documentation for the new SQL (outbound) connector.
Note: these changes will be introduced with 8.6-alpha2.
Product hub Epic here.
Implementation PR here.
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
I have added changes to the relevantthey are not for an already released version./versioned_docs
directory, or/docs
directory (aka/next/
), or they are not for future versions