Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add azure backup configuration to broker configuration page. #3518

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

rodrigo-lourenco-lopes
Copy link
Contributor

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes commented Mar 25, 2024

Description

The broker configuration for azure was missing here.

Changes were added in line to what we have in here.

The azure backups are only present in 8.5 minor.

closes #3485

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.4/.

  • docs/self-managed/zeebe-deployment/configuration/broker.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley requested review from christinaausley and removed request for akeller March 25, 2024 15:21
@christinaausley christinaausley added component:zeebe Issues related with Zeebe project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Mar 25, 2024
@christinaausley
Copy link
Contributor

@akeller is OOO, so I'll have a look here 👍

@christinaausley christinaausley requested a review from megglos March 26, 2024 15:13
@christinaausley
Copy link
Contributor

Is this only applicable to the next version of docs? If not, we should likely backport. Let me know if you would like assistance with this.

@rodrigo-lourenco-lopes
Copy link
Contributor Author

Is this only applicable to the next version of docs? If not, we should likely backport. Let me know if you would like assistance with this.

Yes correct, this feature was not backported.

christinaausley
christinaausley previously approved these changes Apr 2, 2024
christinaausley
christinaausley previously approved these changes Apr 2, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes merged commit 37d7a7f into main Apr 3, 2024
6 checks passed
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes deleted the rl-document-azure-envs branch April 3, 2024 13:53
theburi pushed a commit that referenced this pull request Apr 3, 2024
)

* doc: add azure backup configuration to broker configuration page.

* minor typo

* style(formatting): technical review

* revert change

* Update docs/self-managed/zeebe-deployment/configuration/broker.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update docs/self-managed/zeebe-deployment/configuration/broker.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Christina Ausley <[email protected]>
Co-authored-by: christinaausley <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
theburi pushed a commit that referenced this pull request Jun 5, 2024
)

* doc: add azure backup configuration to broker configuration page.

* minor typo

* style(formatting): technical review

* revert change

* Update docs/self-managed/zeebe-deployment/configuration/broker.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update docs/self-managed/zeebe-deployment/configuration/broker.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Christina Ausley <[email protected]>
Co-authored-by: christinaausley <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed component:zeebe Issues related with Zeebe project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Azure Backup Zeebe Env Variables
2 participants