-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Local deployment guide with connectivity topics #3509
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.4/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
docs/self-managed/platform-deployment/helm-kubernetes/guides/local-kubernetes-cluster.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/local-kubernetes-cluster.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to clarify a few sections.
Additionally, I'm not sure we need to break this up into tabs. I think we can keep everything within a single file here, particularly given the trouble we've been having with deep-linking to tabbed content lately.
docs/self-managed/platform-deployment/helm-kubernetes/guides/local-kubernetes-cluster.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/local-kubernetes-cluster.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/local-kubernetes-cluster.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/local-kubernetes-cluster.md
Outdated
Show resolved
Hide resolved
I find one large file gets newcomers confused as it's hard to follow, and ignore sections. Tabs create a single flow, hiding sections and avoiding confusion. |
Is this linked to a particular issue and is this for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👍
* First pass on local deployment and adding ingress configuration * style(formatting): technical review * Several fixed * adding links to ingress * minor adjustments --------- Co-authored-by: Christina Ausley <[email protected]>
Description
My goal is to improve the local deployment guide to help users do E2E
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.