doc(helm-guides): add example app installation #3508
Conversation
leiicamundi
added
the
best-practices
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md
Outdated
Show resolved
Hide resolved
...on-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
(Reviewing this PR instead of Lars)
I've left some comments on the wording. Additional thing missing in this PR, is that the new pages (in order to appear on the left sidebar in the table of contents) need to be added to https://github.com/camunda/camunda-docs/blob/main/sidebars.js and https://github.com/camunda/camunda-docs/blob/main/optimize_sidebars.js in the corresponding version branches.
...on-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md
Outdated
Show resolved
Hide resolved
...on-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md
Outdated
Show resolved
Hide resolved
...on-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md
Outdated
Show resolved
Hide resolved
...on-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md
Outdated
Show resolved
Hide resolved
|
@leiicamundi is this still in |
|
Hey @christinaausley, yes this is still a draft, we are waiting until camunda-community-hub/camunda-8-examples#342 is merged. Until that, this PR should remain stalled |
…nstalling-payment-example.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…lm-kubernetes/guides/installing-payment-example.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…lm-kubernetes/guides/installing-payment-example.md Co-authored-by: Maxim Danilov <[email protected]>
…lm-kubernetes/guides/installing-payment-example.md Co-authored-by: Maxim Danilov <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leiicamundi
force-pushed
the
feature/payment-example-app
branch
from
c6ca9d1 to
82ade83
Compare
|
Hello @maxdanilov, @christinaausley The PR camunda-community-hub/camunda-8-examples#342 is now merged! I've rebased this PR branch onto the latest main and done the necessary adjustment for the new doc structure. Could you please review it? Thank you in advance! ;) |
There was a problem hiding this comment.
Content-wise LGTM, one missing thing is sidebars (they are versioned as well), in this case:
- https://github.com/camunda/camunda-docs/blob/main/versioned_sidebars/version-8.4-sidebars.json
- https://github.com/camunda/camunda-docs/blob/main/versioned_sidebars/version-8.5-sidebars.json
(should be updated because a new page is added)
|
Ty @maxdanilov, I hadn't seen that the sidebar was versioned, fixed by 4a2d278 |
|
I'll get this reviewed today 👍 |
* doc(helm-guides): add example app installation * Update docs/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update versioned_docs/version-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update versioned_docs/version-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md Co-authored-by: Maxim Danilov <[email protected]> * Update versioned_docs/version-8.4/self-managed/platform-deployment/helm-kubernetes/guides/installing-payment-example.md Co-authored-by: Maxim Danilov <[email protected]> * doc(helm-guides): update payment app example * Update optimize_sidebars.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * doc(sm): payment app example updated with new doc structure * doc(sm): payment app example add versioned sidebars * style(formatting): technical review * style(formatting): shorten title --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxim Danilov <[email protected]> Co-authored-by: Christina Ausley <[email protected]> Co-authored-by: christinaausley <[email protected]>
Description
This PR extends the existing EKS guide by incorporating the demo payment example C8 application, developed by @ingorichtsmeier, which serves as a validation tool for the C8 stack. The objective is to showcase a working example within the EKS environment.
When should this change go live?
PR Checklist
/versioned_docsdirectory, or they are not for an already released version./docsdirectory (aka/next/), or they are not for future versions.