-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(self-managed): platform deployment keycloak irsa update: add cam… #3460
Merged
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0dff036
docs(self-managed): platform deployment keycloak irsa update: add cam…
leiicamundi 2800c01
docs(self-managed): platform deployment keycloak irsa update: add cam…
leiicamundi 12f5ff7
doc(self-managed): applied suggested changes
leiicamundi f7e0635
doc(self-managed): update keycloak image to use bitnami fork
leiicamundi 7551b22
doc(self-managed): update keycloak image to use bitnami fork
leiicamundi 256bed4
doc(self-managed): add reference to official keycloak doc
leiicamundi ba5cc18
Update docs/self-managed/platform-deployment/helm-kubernetes/platform…
leiicamundi 373ae82
Update versioned_docs/version-8.4/self-managed/platform-deployment/he…
leiicamundi d69839d
docs(self-managed): remove mention of gradle
leiicamundi 2b40466
docs(self-managed): add missing driver configuration for keycloak irsa
leiicamundi 61defd7
docs(self-managed): add helm configuration for keycloak irsa
leiicamundi 1ec02cd
Update docs/self-managed/platform-deployment/helm-kubernetes/platform…
leiicamundi de68587
Update versioned_docs/version-8.4/self-managed/platform-deployment/he…
leiicamundi 583293a
docs(self-managed): fix absolute links
leiicamundi bbb97eb
docs(self-managed): apply suggestion
leiicamundi a319ab0
Update docs/self-managed/platform-deployment/helm-kubernetes/platform…
leiicamundi aba2ff4
fix link
leiicamundi 069c8c0
style(formatting): technical review
christinaausley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that H4 and H5 headers will render equal to, if not slightly smaller than the standard text.
Would love to avoid this if possible, but will also circle back to it in https://github.com/camunda/developer-experience/issues/257.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, @christinaausley!
In my opinion, I believe it's acceptable; HTML is primarily intended to be semantic.
Though it's smaller, it doesn't render like text; the bold style and margins distinctly denote it as a section.