-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable check-anchors #3442
base: main
Are you sure you want to change the base?
Enable check-anchors #3442
Conversation
I'm doing a timeboxed investigation here for the anchor link errors. This PR only adjusts the GHA, not the local build. Tabs are not linkable as headings
Some are due to converting sectioned content into tabbed content. Docusaurus tabs do a good job of presenting tabbed content; however, "This feature does not provide an anchor link - the browser will not scroll to the tab." In this case, I would choose to remove them and add text to refer to the table immediately below. Headers renamed (examples - setup vs set-up, drop "platform")
There are about 65 instances of this example alone (setup vs. set-up). I have #3445 in draft addressing some of the points above, but I need to pivot to other time sensitive and critical work. If I have more time today I'll revisit. |
FYI @christinaausley ☝️ see my comment above. When we do renaming and restructuring, we'll need to consider the anchor links as well. Once this check is enabled in our build process, it will be easier to see. |
@conceptualshark have you run into any issues with anchors as you are working through Self-Managed docs? I'm trying to decide what to do with this PR. |
@akeller There's no small amount of them, mostly relating to linking to or between tabbed content. Would you like me to break out a task to address anchors throughout SM, similar to how the others sections have been approached? |
If tackling the amount of broken anchor links is too much to account for right now, we could always include this as a manual workflow to check before a release (as with external links). After a few rounds of this, we could implement |
Yes, basically approach this with "best effort" for your area so we can keep discussing as a team how we want to handle tabs. |
Perhaps we should bring this to a tech writers sync or team meeting? CC @camunda/tech-writers |
Description
This PR enables the check-anchors option
closes #3433
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.