Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document signal catch and throw events #2708

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

korthout
Copy link
Member

@korthout korthout commented Oct 6, 2023

Description

This documents the signal catch and throw events that are newly supported in 8.3.

In 8.2, only the top-level signal start event was supported. With 8.3, support for all other signal events is added. See camunda/camunda#10777 for an overview of signals, or see the individual sections:

closes #2458
closes #1956
closes #1895

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

I think this will be described in the 8.3 release blog post, but I'm not sure.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

There are now two ways to broadcast signals. In 8.2, only the RPC could
be used, but in 8.3 we've introduced signal throw events and signal end
events.

These events don't have their own documentation paragraphs yet, so I'll
link them later.

I've taken the opportunity to rewrite some sections to reuse specific
words like broadcast and trigger.
Signal can have a negative performance impact starting from C8.3, where
signals are broadcasted to all partitions and can trigger signal
subscriptions of process instances.

We must teach users about this impact. While I'd love to see some best
practices for signal events in the future, I think it's enough for now
to document the performance impact as reference details.
In 8.3, we introduce the ability to delete resources
(processes/decisions). This can have an affect on signal start events
when the process that contains them is deleted, or when the previous
version contains them.
With 8.3, new signal catch and throw events have been introduced. I've
added a description for them, and marked them as covered.
Intermediate signal events can also be attached to event-based-gateways.
I've updated the description, example, and image.
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
All committers have signed the CLA.

christinaausley
christinaausley previously approved these changes Oct 7, 2023
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment but looks good 👍

docs/components/concepts/signals.md Show resolved Hide resolved
It's hard to tell users when to use signals and when they shouldn't. It's very dependent on independent use-cases. Instead of recommending, we should aim to inform the user. This is what this warning already does. With this information users can decide themselves if this fits their use-case.
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @korthout 🙇 I only made one small fix the warning. Enjoy your holiday! 🍹

docs/components/concepts/signals.md Show resolved Hide resolved
@remcowesterhoud remcowesterhoud enabled auto-merge (squash) October 9, 2023 09:35
@remcowesterhoud remcowesterhoud merged commit 00776c2 into main Oct 9, 2023
@remcowesterhoud remcowesterhoud deleted the korthout-2458-signal-catch-events branch October 9, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document Signal Catch Events Document Signal Intermediate Throw Event Document Signal End Event
4 participants