Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update writing-good-workers.md #2683

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Update writing-good-workers.md #2683

merged 4 commits into from
Oct 10, 2023

Conversation

berndruecker
Copy link
Member

Description

See #2446 (comment) - the table was broken and is now fixed

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@akeller akeller added component:docs Documentation improvements, including new or updated content best-practices Issues related to the Best Practices section of the docs labels Oct 4, 2023
@akeller
Copy link
Member

akeller commented Oct 4, 2023

@berndruecker this table is still empty. Are you missing a commit with content for this table?

This loaded a previous commit when I ran it locally, my mistake!

@akeller
Copy link
Member

akeller commented Oct 4, 2023

This needs to be backported.

pepopowitz
pepopowitz previously approved these changes Oct 4, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@christinaausley
Copy link
Contributor

christinaausley commented Oct 6, 2023

Hi @berndruecker! Please sign the CLA one more time 😄

@akeller akeller enabled auto-merge (squash) October 10, 2023 20:44
@akeller akeller merged commit 80ed966 into main Oct 10, 2023
4 checks passed
@akeller akeller deleted the berndruecker-patch-1 branch October 10, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best-practices Issues related to the Best Practices section of the docs component:docs Documentation improvements, including new or updated content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants