Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of OS2.5+ support #2621

Merged
merged 13 commits into from
Oct 9, 2023
Merged

Conversation

johanwelgemoed
Copy link
Contributor

@johanwelgemoed johanwelgemoed commented Sep 21, 2023

Remove mention of OS2.5+ support since it will only be announced for Camunda 8.4 release when it is supposed across all components.

Description

When should this change go live?

  • This change is not yet live and should not be merged until 8.3 is released (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

anounced for Camunda 8.4 release
@johanwelgemoed johanwelgemoed added component:zeebe Issues related with Zeebe project component:operate Issues related with Operate project component:tasklist Issues related with Tasklist project component:optimize Issues related with Optimize project labels Sep 21, 2023
@johanwelgemoed johanwelgemoed added the hold This issue is parked, do not merge. label Sep 21, 2023
@johanwelgemoed johanwelgemoed marked this pull request as ready for review September 21, 2023 08:28
@akeller
Copy link
Member

akeller commented Sep 21, 2023

It was accidently removed from 8.2 versioned docs
fixing merge conflicts to prevent overriding information already updated
@johanwelgemoed
Copy link
Contributor Author

In original pr I also removed the mention of OS1.3 support from the versioned docs. This was a mistake so I put it back.

@christinaausley
Copy link
Contributor

Let me know if you need any additional assistance with this or with the build and when you are ready for final review 👍

@johanwelgemoed
Copy link
Contributor Author

@christinaausley I think this one should be ok to review. When I initially did it I was a bit overzealous and removed the mentioned of OpenSearch support in the /next as well as /versioned docs. It should actually only be removed for the upcoming version, so I put the mention back in the 8.2 parts.

Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go -- but I noticed with versioning you swapped a few things back in/out. To confirm, we will have this removal in the 8.4 version, and the Elasticsearch note should remain in 8.2?

If so, I'll remove the label and merge this late this week/early next week before the release.

@johanwelgemoed
Copy link
Contributor Author

johanwelgemoed commented Oct 4, 2023 via email

@christinaausley
Copy link
Contributor

@johanwelgemoed great! I'll merge this in on Monday 👍

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@christinaausley christinaausley removed the hold This issue is parked, do not merge. label Oct 6, 2023
@christinaausley
Copy link
Contributor

@johanwelgemoed Please sign the CLA and we can get this merged 👍 Removed the hold label!

@christinaausley christinaausley merged commit 445eaa0 into main Oct 9, 2023
4 checks passed
@christinaausley christinaausley deleted the remove_mentioned_OpenSearch branch October 9, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:operate Issues related with Operate project component:optimize Issues related with Optimize project component:tasklist Issues related with Tasklist project component:zeebe Issues related with Zeebe project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants