-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mention of OS2.5+ support #2621
Conversation
anounced for Camunda 8.4 release
It was accidently removed from 8.2 versioned docs
fixing merge conflicts to prevent overriding information already updated
In original pr I also removed the mention of OS1.3 support from the versioned docs. This was a mistake so I put it back. |
Let me know if you need any additional assistance with this or with the build and when you are ready for final review 👍 |
@christinaausley I think this one should be ok to review. When I initially did it I was a bit overzealous and removed the mentioned of OpenSearch support in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to go -- but I noticed with versioning you swapped a few things back in/out. To confirm, we will have this removal in the 8.4 version, and the Elasticsearch note should remain in 8.2?
If so, I'll remove the label and merge this late this week/early next week before the release.
Yes, it stays in 8.2 but is removed from 8.3
…________________________________
From: christinaausley ***@***.***>
Sent: 03 October 2023 21:23
To: camunda/camunda-docs ***@***.***>
Cc: Johan Welgemoed ***@***.***>; Assign ***@***.***>
Subject: Re: [camunda/camunda-docs] Remove mention of OS2.5+ support (PR #2621)
@christinaausley approved this pull request.
This should be good to go -- but I noticed with versioning you swapped a few things back in/out. To confirm, we will have this removal in the 8.4 version, and the Elasticsearch note should remain in 8.2?
If so, I'll remove the label and merge this late this week/early next week before the release.
—
Reply to this email directly, view it on GitHub<#2621 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A23FGVI3MQKYJC7OZN3Q62LX5RQ2TAVCNFSM6AAAAAA5BELTWKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJVHE2TSNZXHE>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
@johanwelgemoed great! I'll merge this in on Monday 👍 |
@johanwelgemoed Please sign the CLA and we can get this merged 👍 Removed the |
Remove mention of OS2.5+ support since it will only be announced for Camunda 8.4 release when it is supposed across all components.
Description
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.