-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
archive (1.3) exclude: remove versions 1.3 and 3.7.0, part 1: reviewable steps #2502
Changes from all commits
75a3fe5
53c27a6
7b84279
128874d
225d5d1
387d3ac
0442e77
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ sed -i '' "/^const versionMappings = \[$/,/\];/c\\ | |
const versionMappings = [\\ | ||
{ docsVersion: \"$ARCHIVED_VERSION\", optimizeVersion: \"$ARCHIVED_OPTIMIZE_VERSION\" },\\ | ||
];\\ | ||
" src/mdx/expandVersionedUrl.js | ||
" src/versions.js | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these |
||
|
||
# remove hard-coded versions from main docs sidebar configuration | ||
sed -i '' "s/optimize\/$ARCHIVED_OPTIMIZE_VERSION\//optimize\//g" versioned_sidebars/version-$ARCHIVED_VERSION-sidebars.json | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,7 +48,7 @@ To create the new versions: | |
> ./hacks/cutNewVersions.sh | ||
``` | ||
|
||
4. Add a record correlating the two versions to [`src/mdx/expandVersionedUrl.js`](../src/mdx/expandVersionedUrl.js#L20-L27). | ||
4. Add a record correlating the two versions to [`src/versions.js`](../src/versions.js#L16-L30). | ||
|
||
- The `versionMappings` variable maps Optimize versions to main docs versions: | ||
|
||
|
@@ -63,7 +63,7 @@ To create the new versions: | |
]; | ||
``` | ||
|
||
- Add the new mapping in the first position of the array. | ||
- Order of the items in the array is important. Add the new mapping in the first position of the array, because the first item is treated as the "current" version mapping. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added this note because I think it's important. I only noticed it missing because I was editing the docs right above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Solid add! |
||
|
||
5. Ensure the "unmaintained" banner does not appear for supported versions. We currently support all versions of Camunda Platform 8 since none are older than 18 months. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
["3.10.0", "3.9.0", "3.8.0", "3.7.0"] | ||
["3.10.0", "3.9.0", "3.8.0"] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// @ts-check | ||
|
||
// Note: these type definitions are only checked within an editor. We aren't set up | ||
// for type-checking in the build (yet!) but having these types defined helped me write this code. | ||
/** | ||
* @typedef {object} VersionMapping | ||
* @property {string} docsVersion | ||
* @property {string} optimizeVersion | ||
* | ||
* @typedef {object} UnsupportedVersion | ||
* @property {string} label | ||
* @property {string} urlSuffix | ||
*/ | ||
|
||
/** @type {Array<VersionMapping>} */ | ||
const versionMappings = [ | ||
// 👋 When cutting a new version, add a new mapping here! | ||
{ | ||
docsVersion: "8.2", | ||
optimizeVersion: "3.10.0", | ||
}, | ||
{ | ||
docsVersion: "8.1", | ||
optimizeVersion: "3.9.0", | ||
}, | ||
{ | ||
docsVersion: "8.0", | ||
optimizeVersion: "3.8.0", | ||
}, | ||
]; | ||
|
||
/** @type {Array<UnsupportedVersion>} */ | ||
const unsupportedVersions = [ | ||
// 👋 When archiving a version, move it from the above array into here, and edit it! | ||
{ label: "1.3 / 3.7.0", urlSuffix: "1.3" }, | ||
{ label: "1.2", urlSuffix: "1.2" }, | ||
{ label: "1.1", urlSuffix: "1.1" }, | ||
{ label: "1.0", urlSuffix: "1.0" }, | ||
{ label: "0.26", urlSuffix: "0.26" }, | ||
{ label: "0.25", urlSuffix: "0.25" }, | ||
]; | ||
|
||
module.exports = { | ||
versionMappings, | ||
unsupportedVersions, | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
["8.2", "8.1", "8.0", "1.3"] | ||
["8.2", "8.1", "8.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved these to a separate file because I wanted to type the array items, and I didn't want to clutter this already-large config.