Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to [email protected] #329

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

marstamm
Copy link
Member

@marstamm marstamm commented Dec 5, 2023

Would be cool to get this into the 5.18 release

@marstamm marstamm requested review from smbea and a team December 5, 2023 09:01
@marstamm marstamm self-assigned this Dec 5, 2023
@marstamm marstamm requested review from barmac and removed request for a team December 5, 2023 09:01
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 5, 2023
CHANGELOG.md Outdated
Comment on lines 7 to 11
___Note:__ Yet to be released changes appear here._

### Key Changes in Element Templates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well add the version now so it can be released later 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure if there is anything else outstanding (so it could either be patch/minor release)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we are good to go on other fronts, so I'll add a version number

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also include the DEPS`: update to `[email protected] portion in the changes

@marstamm marstamm force-pushed the bump-element-templates branch from c472629 to 2b71dab Compare December 5, 2023 09:13
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment but good to go otherwise

@marstamm marstamm force-pushed the bump-element-templates branch from 2b71dab to 5ffca34 Compare December 5, 2023 09:16
@marstamm
Copy link
Member Author

marstamm commented Dec 5, 2023

Thanks, I changed the Changelog and will go ahead and release 🚀

@marstamm marstamm merged commit a57fc06 into main Dec 5, 2023
8 checks passed
@marstamm marstamm deleted the bump-element-templates branch December 5, 2023 09:17
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants