Implementation of UpdateJobTimeoutCommand #682
Conversation
|
|
LennartKleymann
force-pushed
the
681-add-update-job-timeout-command
branch
from
feb37b4 to
f59c5e0
Compare
LennartKleymann
force-pushed
the
681-add-update-job-timeout-command
branch
from
f59c5e0 to
7b69dc7
Compare
There was a problem hiding this comment.
Awesome! Thanks for your great contribution @LennartKleymann 🚀
There are only smaller things we have to add/do and then we can merge it. Actually, it is just to add a separate test class for the command, and clarify the timeout conversion. :)
Thanks for your time and effort!
| yield return new TestCaseData( | ||
| new UpdateJobTimeoutRequest() |
There was a problem hiding this comment.
👍🏼 Great that you added here an test case as well.
As this is only for the SendWithRetry test right now we also need some more tests for the happy path to check the expected requests, and responses. Like we do with the other commands. Take as example this https://github.com/camunda-community-hub/zeebe-client-csharp/blob/main/Client.UnitTests/UpdateRetriesTest.cs
What we also need is to add
There was a problem hiding this comment.
I added tests to check expected requests
Added a command for updating the timeout of a job
closes #681