fix: set adapter.connected = False on channel closing

pyzeebe/grpc_internals/zeebe_adapter_base.py

@@ -21,11 +21,15 @@ class ZeebeAdapterBase:
     def __init__(self, grpc_channel: grpc.aio.Channel, max_connection_retries: int = -1):
         self._channel = grpc_channel
         self._gateway_stub = GatewayStub(grpc_channel)
-        self.connected = True
+        self._connected = True
         self.retrying_connection = False
         self._max_connection_retries = max_connection_retries
         self._current_connection_retries = 0
 
+    @property
+    def connected(self) -> bool:
+        return self._connected
+
     def _should_retry(self) -> bool:
         return self._max_connection_retries == -1 or self._current_connection_retries < self._max_connection_retries
 
@@ -41,6 +45,7 @@ async def _handle_grpc_error(self, grpc_error: grpc.aio.AioRpcError) -> NoReturn
 
     async def _close(self) -> None:
         try:
+            self._connected = False
             await self._channel.close()
         except Exception as exception:
             logger.exception("Failed to close channel, %s exception was raised", type(exception).__name__)

tests/unit/worker/job_poller_test.py

@@ -46,13 +46,13 @@ async def test_job_is_added_to_task_state(
 
 class TestShouldPoll:
     def test_should_poll_returns_expected_result_when_disconnected(self, job_poller: JobPoller):
-        job_poller.zeebe_adapter.connected = False
+        job_poller.zeebe_adapter._connected = False
         job_poller.zeebe_adapter.retrying_connection = False
 
         assert not job_poller.should_poll()
 
     def test_continues_polling_when_retrying_connection(self, job_poller: JobPoller):
-        job_poller.zeebe_adapter.connected = False
+        job_poller.zeebe_adapter._connected = False
         job_poller.zeebe_adapter.retrying_connection = True
 
         assert job_poller.should_poll()