Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metadata query when role === "any" #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YousefED
Copy link

if role is set to "any", we don't need to query the metadata service explicitly.

node aws-sdk will already use the correct credentials by itself

@trexx
Copy link

trexx commented Jun 1, 2017

Thanks, this is very handy.
When using roles, by default AWS access keys and ID's expire after 12 hours. A new key or ID isn't fetched when this happens so this backend will fail to upload metrics to cloudwatch.
aws-sdk will fetch new credentials as they approach expiry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants