Fixing the dst type, which is expected to be *mut i8 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
245 | std::ptr::copy_nonoverlapping(self.as_ptr().cast::<i8>(), dst, self.len());
| ----------------------------- ^^^ expected `*mut i8`, found `*mut u8`
| |
| arguments to this function are incorrect
bschwind
reviewed
Nov 1, 2024
| @@ -242,7 +242,7 @@ impl CopyTo for &str { | |||
| if *dst_size < string_len { | |||
| return Err(GenTlError::BufferTooSmall); | |||
| } | |||
| std::ptr::copy_nonoverlapping(self.as_ptr().cast::<i8>(), dst, self.len()); | |||
| std::ptr::copy_nonoverlapping(self.as_ptr().cast::<i8>(), dst.cast::<i8>(), self.len()); | |||
There was a problem hiding this comment.
Right, libc::c_char can be an i8 or a u8 depending on the platform.
&str.as_ptr() always returns a *const u8 as far as I'm aware, so it almost makes more sense to cast dst to a u8 pointer and remove the cast on self.as_ptr().
To be honest this whole function feels a bit precarious and should probably be using CString and CStr but I guess that's a bigger conversation.
@strohel what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your hard work on cameleon, this is a great project!
This trivial PR fixes an error occured during my compilation, possibly with a newer version of Rust compiler:
Changelog
*mut u8to*mut i8instd::ptr::copy_nonoverlapping.