Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telegraf adapter for commands and improve MQTT configuration #177

Merged
merged 4 commits into from
Aug 31, 2024
Merged

Telegraf adapter for commands and improve MQTT configuration #177

merged 4 commits into from
Aug 31, 2024

Conversation

calvinmclean
Copy link
Owner

  • Use Telegraf to record commands coming from the server instead of just recording data from the controller. This is another step towards full traceability of events and communication to the controller
  • Remove MQTT topics from configs to make things simpler and more consistent. The previous level of config customizability is not necessary and makes things more confusing
  • Move MQTT topics for controller into mqtt.h instead of config.h

@calvinmclean
Update Telegraf config to record commands
52a58e3
@calvinmclean
Move MQTT topics to const instead of config
e9f7e9b 
- This simplifies things since there isn't a strong reason for
  changing the MQTT topics and it would disrupt other configs
- Also simplifies client mocks since topics are no longer variable
@calvinmclean
Simplify topic configs for Telegraf
be9b16e
@calvinmclean
Move topic-related controller configs to mqtt.h
6e8abf6 
- Since these fields aren't going to be configured by the user, they
  should not be in the user-modified config.h file
@calvinmclean calvinmclean merged commit 9fafe91 into main Aug 31, 2024
6 checks passed
@calvinmclean calvinmclean deleted the feature/record-commands branch August 31, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@calvinmclean