Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour Schema Refactor #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Waidhoferj
Copy link
Member

@Waidhoferj Waidhoferj commented Jul 25, 2021

Refactors the tour schema to consistently match the output of the Argo Editor

Changes

  • Refactored explicit classes to structural types to allow for a dynamic schema.
  • Abstracted away the need for a parser and graph classes to reduce complexity and improve performance.
  • Unified the data schema between the Argo Editor and this repo.
  • Position modals based on a spherical coordinate system that is invariant to changes in the texture sphere sizing.
  • Added portal functionality.

Testing

@Waidhoferj Waidhoferj added the enhancement New feature or request label Jul 25, 2021
@Waidhoferj Waidhoferj self-assigned this Jul 25, 2021
@Waidhoferj Waidhoferj marked this pull request as ready for review August 8, 2021 23:53
@Waidhoferj
Copy link
Member Author

While this can be reviewed now, it will only work locally. I recommend that we get deployment to work first before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant