Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A notebook for listening to pronunciation in other languages #206

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

misterhay
Copy link
Contributor

No description provided.

@misterhay misterhay requested a review from a user February 20, 2021 15:52
@misterhay
Copy link
Contributor Author

Looks like CI is failing because gtts and googletrans are not working on the Callysto Hub. Both work locally however.

@ianabc
Copy link
Member

ianabc commented Mar 10, 2021

As far as I can tell this is down to google (repeatedly) changing their API. The same issue is discussed in py-googletrans/234. They mention an alpha release version which currently works around the problem in py-googletrans/issues/280 but it looks like google has done this a few times before. I'll try to roll the alpha into the new image but this might come back.

EDIT: I've updated the image on hub.callysto.ca can you try deploying this again and see if it still fails?

@misterhay
Copy link
Contributor Author

As far as I can tell this is down to google (repeatedly) changing their API. The same issue is discussed in py-googletrans/234. They mention an alpha release version which currently works around the problem in py-googletrans/issues/280 but it looks like google has done this a few times before. I'll try to roll the alpha into the new image but this might come back.

EDIT: I've updated the image on hub.callysto.ca can you try deploying this again and see if it still fails?

It worked, thank you :)

@byrcyb byrcyb self-requested a review March 19, 2021 23:10
Copy link
Contributor

@byrcyb byrcyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pretty fun little notebook.

@byrcyb byrcyb merged commit b8ca6cc into master Mar 19, 2021
@byrcyb byrcyb deleted the pronunciation branch March 19, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants