Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: measure available space for views on iOS #170

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

okwasniewski
Copy link
Collaborator

@okwasniewski okwasniewski commented Dec 1, 2024

PR Description

This PR introduces measuring available space for views so that they get laid out properly. This is internal only change that doesnt affect public API.

This should also unblock #46

Should fix:

How to test?

Check above issues after applying those changes.

Screenshots

N/A

Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: d36b21e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
react-native-bottom-tabs Patch
@bottom-tabs/react-navigation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okwasniewski okwasniewski marked this pull request as ready for review December 3, 2024 11:07
@okwasniewski
Copy link
Collaborator Author

Next release should bring much better support for sidebarAdaptable

CleanShot.2024-12-03.at.12.25.26.mp4

@okwasniewski okwasniewski merged commit ff71011 into main Dec 3, 2024
6 checks passed
@okwasniewski okwasniewski deleted the fix/measure-views branch December 3, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant