fix: update tint colors after updating items (#195)

* feat: add react-native-edge-to-edge * fix: update tint colors after updating items * Create rude-ants-heal.md
callstackincubator · Dec 12, 2024 · 2526db9 · 2526db9
1 parent dc5ebe7
commit 2526db9
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 7 deletions.
diff --git a/.changeset/rude-ants-heal.md b/.changeset/rude-ants-heal.md
@@ -0,0 +1,5 @@
+---
+"react-native-bottom-tabs": patch
+---
+
+fix: update tint colors after updating items
diff --git a/apps/example/app.json b/apps/example/app.json
@@ -9,6 +9,9 @@
       "slug": "bottomtabs-example"
     }
   ],
+  "plugins": [
+    ["react-native-edge-to-edge", {"android": {"parentTheme": "Material3"}}]
+  ],
   "resources": {
     "android": [
       "dist/res",

diff --git a/apps/example/package.json b/apps/example/package.json
@@ -26,6 +26,7 @@
     "react": "18.3.1",
     "react-native": "0.75.4",
     "react-native-bottom-tabs": "*",
+    "react-native-edge-to-edge": "^1.1.3",
     "react-native-gesture-handler": "^2.21.2",
     "react-native-macos": "^0.75.0",
     "react-native-paper": "^5.12.5",

diff --git a/apps/example/src/App.tsx b/apps/example/src/App.tsx
@@ -10,7 +10,6 @@ import {
   TouchableOpacity,
   Button,
   Alert,
-  useColorScheme,
   Platform,
 } from 'react-native';
 import { NavigationContainer, useNavigation } from '@react-navigation/native';

diff --git a/packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt b/packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
@@ -138,6 +138,7 @@ class ReactBottomNavigationView(context: Context) : BottomNavigationView(context
           }
         }
         updateTextAppearance()
+        updateTintColors()
       }
     }
   }
@@ -171,12 +172,16 @@ class ReactBottomNavigationView(context: Context) : BottomNavigationView(context
   }
 
   fun setLabeled(labeled: Boolean?) {
-    labelVisibilityMode = if (labeled == false) {
-      LABEL_VISIBILITY_UNLABELED
-    } else if (labeled == true) {
-      LABEL_VISIBILITY_LABELED
-    } else {
-      LABEL_VISIBILITY_AUTO
+    labelVisibilityMode = when (labeled) {
+        false -> {
+          LABEL_VISIBILITY_UNLABELED
+        }
+        true -> {
+          LABEL_VISIBILITY_LABELED
+        }
+        else -> {
+          LABEL_VISIBILITY_AUTO
+        }
     }
   }
 

diff --git a/yarn.lock b/yarn.lock
@@ -15591,6 +15591,7 @@ __metadata:
     react-native: 0.75.4
     react-native-bottom-tabs: "*"
     react-native-builder-bob: ^0.30.2
+    react-native-edge-to-edge: ^1.1.3
     react-native-gesture-handler: ^2.21.2
     react-native-macos: ^0.75.0
     react-native-paper: ^5.12.5
@@ -15686,6 +15687,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"react-native-edge-to-edge@npm:^1.1.3":
+  version: 1.1.3
+  resolution: "react-native-edge-to-edge@npm:1.1.3"
+  peerDependencies:
+    react: ">=18.2.0"
+    react-native: ">=0.73.0"
+  checksum: 712c4cab722640dee0153fe7ba5663cb34a3a30310a9e3792678ac2b58b9cf6acd1677a2cdd73b63aeca3bfa99e5fb6f18cded7752f52ed3aa0eea120e39916d
+  languageName: node
+  linkType: hard
+
 "react-native-gesture-handler@npm:2.21.2, react-native-gesture-handler@npm:^2.21.2":
   version: 2.21.2
   resolution: "react-native-gesture-handler@npm:2.21.2"