fix: remove tab bar icon workaround (#157)

* fix: remove tab bar icon workaround * Create bright-pianos-invite.md
callstackincubator · Nov 22, 2024 · 153f5f7 · 153f5f7
1 parent f128b02
commit 153f5f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/.changeset/bright-pianos-invite.md b/.changeset/bright-pianos-invite.md
@@ -0,0 +1,5 @@
+---
+"@bottom-tabs/react-navigation": patch
+---
+
+fix: remove `tabBarIcon` from experimental API 
diff --git a/packages/react-navigation/src/types.ts b/packages/react-navigation/src/types.ts
@@ -67,12 +67,6 @@ export type NativeBottomTabNavigationOptions = {
    */
   tabBarIcon?: (props: { focused: boolean }) => ImageSourcePropType | AppleIcon;
 
-  /**
-   * Whether the tab bar item is visible when this screen is active.
-   * Used for compatibility with JS Tabs. Prefer using `tabBarItemHidden` as this API may be removed in the future.
-   */
-  tabBarButton?: () => null;
-
   /**
    * Whether the tab bar item is visible. Defaults to true.
    */

diff --git a/packages/react-navigation/src/views/NativeBottomTabView.tsx b/packages/react-navigation/src/views/NativeBottomTabView.tsx
@@ -42,11 +42,7 @@ export default function NativeBottomTabView({
       getBadge={({ route }) => descriptors[route.key]?.options.tabBarBadge}
       getHidden={({ route }) => {
         const options = descriptors[route.key]?.options;
-
-        return (
-          options?.tabBarItemHidden === true ||
-          options?.tabBarButton?.() === null
-        );
+        return options?.tabBarItemHidden === true;
       }}
       getIcon={({ route, focused }) => {
         const options = descriptors[route.key]?.options;