Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

130 crash when supplying commit argument #133

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

coordt
Copy link
Member

@coordt coordt commented Jan 25, 2024

Fixes missing current version in the context and bad error reporting

Fixes #130
Fixes #131

@coordt coordt linked an issue Jan 25, 2024 that may be closed by this pull request
Copy link

Version hint: patch
Current version: 0.17.0
New version (when merged): 0.17.1

Comment ID: Display the version hint-auto-generated

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c15b23b) 93.22% compared to head (10e5d7d) 92.83%.
Report is 2 commits behind head on master.

Files Patch % Lines
bumpversion/scm.py 14.28% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   93.22%   92.83%   -0.40%     
==========================================
  Files          21       21              
  Lines        1403     1409       +6     
  Branches      292      294       +2     
==========================================
  Hits         1308     1308              
- Misses         66       70       +4     
- Partials       29       31       +2     
Flag Coverage Δ
python-3.10 92.83% <33.33%> (-0.40%) ⬇️
python-3.11 92.83% <33.33%> (-0.40%) ⬇️
python-3.8 92.83% <33.33%> (-0.40%) ⬇️
python-3.9 92.83% <33.33%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt merged commit 3bcec28 into master Jan 25, 2024
11 of 13 checks passed
@coordt coordt deleted the 130-crash-when-supplying-commit-argument branch January 25, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing after switch to subprocess Crash when supplying --commit argument
2 participants