Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyomo breakage #713

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Fix pyomo breakage #713

merged 5 commits into from
Nov 19, 2024

Conversation

irm-codebase
Copy link
Contributor

@irm-codebase irm-codebase commented Nov 16, 2024

Fixes #710

Summary of changes in this pull request

  • Removed pyomo top limit in hopes to avoid the incompatibility with gurobi 12.0
  • Set pyomo lowerbound to 6.8.2 to avoid breakage in older versions
  • Fixed a couple of broken pyomo links since 6.8.1 also updated their docs

The pyomo folks were quite quick on fixing this one (Pyomo/pyomo#3414). Let's see what our tests have to say about this fix.

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (ed25596) to head (30a4222).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #713    +/-   ##
========================================
  Coverage   95.97%   95.98%            
========================================
  Files          29       29            
  Lines        4048     4057     +9     
  Branches      849      579   -270     
========================================
+ Hits         3885     3894     +9     
  Misses         72       72            
  Partials       91       91            

see 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@brynpickering
Copy link
Member

Nice to see the CI tests are passing. Can you run them locally with gurobipy installed and pytest -m "needs_gurobi_license"? This will do a more thorough check of the gurobi compatability.

@irm-codebase
Copy link
Contributor Author

@brynpickering passing without a hitch!

image

I also ran them with the previous pyomo version I had (6.7.1), and they failed. I've updated the pyomo lowerbound to avoid this problem.

CHANGELOG.md Outdated Show resolved Hide resolved
requirements/base.txt Outdated Show resolved Hide resolved
@brynpickering brynpickering self-requested a review November 19, 2024 11:43
@brynpickering brynpickering merged commit dea1c15 into main Nov 19, 2024
13 checks passed
@brynpickering brynpickering deleted the fix-pyomo-breakage branch November 19, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyomo testcase failure with newest gurobi version 12.0.0
2 participants