Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in docs and new data checks #644

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Conversation

sstroemer
Copy link
Contributor

@sstroemer sstroemer commented Jul 26, 2024

Related to #643

Summary of changes in this pull request

  • Small fixes (typos, ...) to docstrings
  • Checks for valid values of flow_cap_* and storage_initial (d99bf94); note that I'm unsure if the check for flow_cap_min <= flow_cap_max is done correctly?

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

src/calliope/config/model_data_checks.yaml Outdated Show resolved Hide resolved
src/calliope/config/model_data_checks.yaml Outdated Show resolved Hide resolved
src/calliope/config/model_data_checks.yaml Outdated Show resolved Hide resolved
src/calliope/config/model_def_schema.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@sstroemer sstroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted all files according to discussion.

brynpickering
brynpickering previously approved these changes Aug 7, 2024
Copy link
Member

@brynpickering brynpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion, otherwise good to go.

I'm thinking we could do something about parameter-level checks as part of solving #642 (defining parameters as part of the YAML math, then having a "data-check" key to add checks at a parameter-level).

@brynpickering
Copy link
Member

@sstroemer please fix the test that is now failing! Plus, add your name to the AUTHORS file.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (4fc6b84) to head (4b011e5).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          26       26           
  Lines        3980     3980           
  Branches      836      767   -69     
=======================================
  Hits         3820     3820           
  Misses         70       70           
  Partials       90       90           

@brynpickering brynpickering merged commit ca5a394 into calliope-project:main Aug 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants