-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in docs and new data checks #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted all files according to discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion, otherwise good to go.
I'm thinking we could do something about parameter-level checks as part of solving #642 (defining parameters as part of the YAML math, then having a "data-check" key to add checks at a parameter-level).
Co-authored-by: Bryn Pickering <[email protected]>
@sstroemer please fix the test that is now failing! Plus, add your name to the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 26 26
Lines 3980 3980
Branches 836 767 -69
=======================================
Hits 3820 3820
Misses 70 70
Partials 90 90 |
Related to #643
Summary of changes in this pull request
flow_cap_*
andstorage_initial
(d99bf94);note that I'm unsure if the check forflow_cap_min <= flow_cap_max
is done correctly?Reviewer checklist