Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework _model_def_dict #641

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Rework _model_def_dict #641

merged 2 commits into from
Jul 19, 2024

Conversation

irm-codebase
Copy link
Contributor

Part of #619

Summary of changes in this pull request

  • Removes unused model._model_def_dict spam in xarray objects and saved data.

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link
Member

@brynpickering brynpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Add to changelog as an internal change?

@irm-codebase irm-codebase merged commit 41b7fe5 into rework-math Jul 19, 2024
1 of 3 checks passed
@irm-codebase irm-codebase deleted the rework-def-dict branch July 19, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants