Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record of single element attribute lists in IO #627

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

brynpickering
Copy link
Member

Fixes #614

Summary of changes in this pull request

  • single element lists / sets are logged and returned to being lists / sets on loading from NetCDF

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (872978d) to head (5281200).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   95.85%   95.35%   -0.51%     
==========================================
  Files          24       24              
  Lines        3619     3656      +37     
  Branches      788      734      -54     
==========================================
+ Hits         3469     3486      +17     
+ Misses         86       82       -4     
- Partials       64       88      +24     
Files with missing lines Coverage Δ
src/calliope/io.py 96.87% <100.00%> (+2.08%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@irm-codebase irm-codebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I just have one question about whether or not the fix can be made more generic.
After that I can approve.

src/calliope/io.py Show resolved Hide resolved
@brynpickering brynpickering merged commit 7254770 into main Jun 30, 2024
12 of 13 checks passed
@brynpickering brynpickering deleted the fix-single-element-attr-lists branch June 30, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect net_cdf serialisation for top level attributes
2 participants